Puppet: System Administration Automated

Support

Ticket #887 (new defect)

Opened 10 months ago

Last modified 5 months ago

Environment variable leak in blastwave provider

Reported by: ctrlaltdel Assigned to: community
Priority: normal Milestone: unplanned
Component: Solaris Version: 0.23.2
Severity: normal Keywords: environment variable blastwave
Cc: francois@ctrlaltdel.ch Triage Stage: Accepted
Attached Patches: None Complexity: Unknown

Description

In provider/package/blastwave.rb: 

    # This is so stupid, but then, so is blastwave.
    ENV["PAGER"] = "/usr/bin/cat"

This environment variable leaks in all other types (such as exec). This could lead to strange behaviours of script launched by an exec because under some OS /usr/bin/cat does not exist.

This problem appeared during an automated Vmware Workstation installation, the vmware-install.pl script failed when run with PAGER=/usr/bin/cat.

Change History

11/19/07 21:28:34 changed by tim

  • stage changed from Unreviewed to Accepted.
  • milestone set to unplanned.

#910 suggests using which cat, but I'm not sure that's a good solution. Don't think it's important enough for misspiggy.

04/24/08 07:08:09 changed by luke

  • component changed from library to Solaris.