Puppet: System Administration Automated

Support

Ticket #1242 (closed defect: fixed)

Opened 6 months ago

Last modified 6 months ago

Collect statements should not throw an exception if storeconfigs is not enabled

Reported by: luke Assigned to: jamtur01
Priority: normal Milestone: 0.24.5
Component: Darwin Version: 0.24.4
Severity: blocker Keywords:
Cc: Triage Stage: Ready for checkin
Attached Patches: None Complexity: Medium

Description

Current, if storeconfigs isn't enabled but you have any collect statements (e.g., File <<| |>>) or exported resources, then the parser throws an exception.

This is bad because it means we can't bootstrap systems that use storeconfigs -- their manifests don't work until storeconfigs works, but the manifests are required in order to get storeconfigs to work.

It might be as simple as just removing the exceptions in grammar.ra (all the tests still pass when I do this), but I expect it actually requires at least modifying parser/collector.rb so it noops if storeconfigs isn't enabled.

Change History

05/21/08 07:54:45 changed by luke

  • status changed from new to assigned.

05/27/08 05:34:48 changed by luke

  • owner changed from luke to jamtur01.
  • status changed from assigned to new.
  • stage changed from Accepted to Ready for checkin.

I've published a fix for this as commit [65c1889] in my tickets/1242 branch.

Note that I didn't test for the warnings, or the lack of exceptions, since it seems a bit weird to test that code is missing.

05/27/08 05:51:28 changed by jamtur01

  • status changed from new to closed.
  • resolution set to fixed.

Pushed to stable 0.24.x.