Puppet: System Administration Automated

Support

Ticket #1195 (closed enhancement: fixed)

Opened 7 months ago

Last modified 7 months ago

Patch to make the Gentoo puppetmaster rc-script openrc compatible

Reported by: thansen Assigned to: luke
Priority: normal Milestone:
Component: server Version: 0.24.4
Severity: normal Keywords:
Cc: Triage Stage: Ready for checkin
Attached Patches: Code Complexity: Unknown

Description

Gentoo is switching to openrc, which breaks the puppetmaster rc-script. The attached patch fixes the problem.

Attachments

0006-Fixed-openrc-compatability.patch (1.0 kB) - added by thansen on 04/17/08 11:46:06.
Fixes openrc compatability

Change History

04/17/08 11:46:06 changed by thansen

  • attachment 0006-Fixed-openrc-compatability.patch added.

Fixes openrc compatability

04/17/08 11:52:56 changed by jamtur01

  • owner changed from community to jamtur01.
  • status changed from new to assigned.
  • stage changed from Unreviewed to Needs more info.

What versions does this impact? I suspect it'd be better to maintain some backward compatibility for older releases.

04/17/08 15:54:51 changed by thansen

This changes is backwards compatible.

openrc includes a version of start-stop-daemon which requires (as opposed to previously being optional) scripts to be started with their interpreter or with a specified pidfile.

04/17/08 17:19:54 changed by jamtur01

  • owner changed from jamtur01 to luke.
  • status changed from assigned to new.
  • stage changed from Needs more info to Ready for checkin.

Pushed in [0a5d8a639014495388b2b6c87c295ab4877f9139] in branch 0.24.x

04/17/08 17:24:41 changed by jamtur01

Not being a Gentoo person does this impact the gentoo service provider at all?

04/17/08 17:50:22 changed by immerda

this is about the init.d script and won't affect any puppet internals.

04/17/08 17:59:42 changed by jamtur01

No - I think you're missing my point. Is this a move to a new init system? If which case does the gentoo provider for the service type need updating? Will the same commands still enable, disable, start/stop, etc services?

04/17/08 18:07:59 changed by immerda

sorry i didn't realize that your question goes so far. ;) according to http://www.gentoo.org/doc/en/openrc-migration.xml it will still use init.d-scripts and the rc-update scripts. which is what the current service-provider (provider/service/gentoo.rb) is using. so imho: no it won't break anything.

04/20/08 06:36:15 changed by luke

  • status changed from new to closed.
  • resolution set to fixed.

Merged and pushed.

Thanks for delving deeper into this, James, and thanks for the more detail, immerda.