Puppet: System Administration Automated

Support

Ticket #1182 (closed enhancement: invalid)

Opened 5 months ago

Last modified 5 months ago

More facts for manufacturer.rb

Reported by: dhill Assigned to: community
Priority: normal Milestone:
Component: client Version: 0.24.2
Severity: normal Keywords: facter, facts, manufacturer
Cc: Triage Stage: Unreviewed
Attached Patches: Code Complexity: Unknown

Description

Playing with Facter, I noticed that while it uses dmidecode (where possible) to get things like the manufacturer and productname, it misses data like the chassis type (desktop, rack mount etc).

Attached is a rude and crude patch to implement a few more facts in manufacturer.rb. No test, not sure how to write one yet, or even if one is needed for this type of change.

The optimum solution is probably a configuration file (ini format, ruby hash format?) that defines the section and the keys from the section, rather than a hard code in the .rb file. I may be able to provide this in a later patch - will start a discussion on the list about that.

Attachments

facter-manufacturer.patch (1.5 kB) - added by dhill on 04/09/08 12:35:31.
Implement desired facts as nested hash

Change History

04/09/08 12:35:31 changed by dhill

  • attachment facter-manufacturer.patch added.

Implement desired facts as nested hash

04/09/08 16:06:14 changed by jamtur01

  • status changed from new to closed.
  • resolution set to invalid.

There is actually a Facter trac at http://reductivelabs.com/trac/facter/ - can you re-post there please.