Puppet: System Administration Automated

Support

Ticket #1179 (closed enhancement: fixed)

Opened 8 months ago

Last modified 6 months ago

Allow to use a single attribute in LDAP to define variables in Puppet

Reported by: wrobel Assigned to: jamtur01
Priority: normal Milestone: 0.24.5
Component: LDAP Version:
Severity: normal Keywords: ldap
Cc: Triage Stage: Ready for checkin
Attached Patches: Code Complexity: Easy

Description

As defining new attributes for LDAP servers requires schema changes it is not really easy to define new variables to be used within puppet via the LDAP hierarchy.

I'd like to suggest adding support for a single, stacked attribute type. In testing I called this attribute "puppetvar" and defined it in the schema. As values for this attribute I used strings that define a puppet variable with "variable=value". Would that be something that makes sense?

I attach a proposed patch. As these are my first lines of ruby code I apologize for any strange syntax. Feel free to correct me.

Attachments

stack_ldap.patch (1.8 kB) - added by wrobel on 04/07/08 18:03:46.
ticket_1179.patch (8.6 kB) - added by wrobel on 05/15/08 10:53:38.
Updated patch for stacked parameters

Change History

04/07/08 18:03:46 changed by wrobel

  • attachment stack_ldap.patch added.

(follow-up: ↓ 2 ) 04/07/08 23:46:53 changed by jamtur01

  • owner changed from community to luke.
  • complexity changed from Unknown to Easy.
  • stage changed from Unreviewed to Needs design decision.

I see what you're trying to achieve. Just not sure it's the right model to pursue. With that in mind I am assigning to Luke for design review.

(in reply to: ↑ 1 ) 04/08/08 07:24:30 changed by wrobel

Replying to jamtur01:

I see what you're trying to achieve. Just not sure it's the right model to pursue.

Me neither :) I'm absolutely open to alternative suggestions.

I need the ability to have some basic profile definitions. Some of these basic definitions will be overwritten by the child profiles or the host specific settings.

I didn't find a good way to do that with puppet using configuration manifests at the moment. And I'd prefer to do it in LDAP. Hence the suggested patch.

With that in mind I am assigning to Luke for design review.

Thanks.

04/24/08 08:14:28 changed by luke

  • component changed from library to unknown.

04/28/08 16:27:09 changed by jamtur01

  • owner changed from luke to community.
  • component changed from unknown to LDAP.

05/13/08 00:06:21 changed by luke

  • stage changed from Needs design decision to Accepted.
  • patch changed from Code to Insufficient.

I'm fine with this functionality, but the patch needs tests attached to it, and it should also include a change to the ldap schema to enable this.

05/15/08 10:53:38 changed by wrobel

  • attachment ticket_1179.patch added.

Updated patch for stacked parameters

05/15/08 10:55:44 changed by wrobel

Thanks for considering it.

I completed the remaining tasks and attached the updated patch.

I also tested github yesterday for the first time and will send you a pull request there. Is that a sensible thing to do?

05/15/08 17:46:41 changed by luke

  • owner changed from community to jamtur01.
  • milestone set to 0.24.5.

I've combined your three commits into one and pushed it into my 0.24.x branch on github.

Your commits were against the master branch, which meant they couldn't have been released until 0.25, which is why I switched branches. The commit squashing was just so that the three related commits showed up together.

05/15/08 17:47:33 changed by luke

  • stage changed from Accepted to Ready for checkin.

05/16/08 08:10:48 changed by jamtur01

  • status changed from new to closed.
  • resolution set to fixed.
  • patch changed from Insufficient to Code.

Fixed in commit [158d3df805ebe28f52db5ced928dda7129aeec1b] in branch 0.24.x