Custom function doesn't work when using multiple environments

Unable to replicate.

puppet.conf:

[main]
environments=production,testing

[production]
manifest=/etc/puppet/env/production/site.pp
modulepath=/etc/puppet/env/production/modules

[puppetd]
environment=production

tests (gsub is a parser function provided by DavidS' common module):

root@junglist (branch: master) /etc/puppet/env/production# cat site.pp
node junglist {
   $ifs = gsub(split($interfaces, " "), "(.+)", "if_\\1")
   notify {
      $ifs:
   }
}
root@junglist (branch: master) /etc/puppet/env/production# puppetd --test --environment production
info: Loading fact configured_ntp_servers
info: Loading fact netmask
info: Loading fact acpi_available
info: Loading fact interfaces
info: Retrieving plugins
notice: Ignoring cache
info: Caching catalog at /var/lib/puppet/state/localconfig.yaml
notice: Starting catalog run
notice: if_eth0,eth0:0,eth0:1,eth0:2,eth0:3,eth1
notice: Finished catalog run in 1.08 seconds

Please provide more details, with specific replication steps if possible.

I can basically guarantee that this bug is valid, because all functions are dynamically defined on the Scope class, which means that they're global to environments.

The only real fix is to move the functions to a stand-alone class or module and make that module be per-environment, or to keep the functions as just blocks, looking up and evaluating them as necessary.

Sample module

Please provide more details, with specific replication steps if possible.

See attachment:sample.tgz

This sample module works in setup without environments and doesn't work when using environments

I can confirme this behaviour. I even tried to manually sync the functions, however they always got overwritten/emptied before compiling and then this failed.

Disabling environments just work fine.

This bug is kind of critical and a bit a locker of proceeding people to newer versions, if they want to use environments.

As Luke mentioned in a mail this fix won't be quite easy to fix. So where would be the best place to start to investigate? How can people help?

After a bit debugging with immerda, we found out that setting an additional global modulepath at least lets the puppetmaster work with those functions, even when using environments.

I'm running with this configuration already for quite a while and ahd no unexpected problems with it:

[main]
environment=production
# Default modulepath without environments
modulepath=/srv/puppet/modules:/etc/puppet/modules:/usr/share/puppet/modules

[production]
modulepath=/srv/puppet/modules:/etc/puppet/modules:/usr/share/puppet/modules

[development]
modulepath=/srv/puppet/modules-development:/etc/puppet/modules:/usr/share/puppet/modules

I'd go so far as to say that the workaround below is sufficient, and I'm not familiar enough with the underlying substructures to actually implement the work suggested by Luke, as such, here you go community!

Replying to DavidS:

After a bit debugging with immerda, we found out that setting an additional global modulepath at least lets the puppetmaster work with those functions, even when using environments. I'm running with this configuration already for quite a while and ahd no unexpected problems with it: {{{ [main] environment=production # Default modulepath without environments modulepath=/srv/puppet/modules:/etc/puppet/modules:/usr/share/puppet/modules [production] modulepath=/srv/puppet/modules:/etc/puppet/modules:/usr/share/puppet/modules [development] modulepath=/srv/puppet/modules-development:/etc/puppet/modules:/usr/share/puppet/modules }}}