Puppet: System Administration Automated

Support

Ticket #1160 (closed enhancement: fixed)

Opened 8 months ago

Last modified 8 months ago

puppet-mode.el updates

Reported by: rra Assigned to: luke
Priority: normal Milestone:
Component: library Version:
Severity: normal Keywords: emacs
Cc: Triage Stage: Ready for checkin
Attached Patches: Code Complexity: Unknown

Description

Attached is a patch that further enhances puppet-mode.el, against the version in the current Git head. This patch does the following:

  • Made the basic indentation relative to puppet-indent-level rather than hard-coding 2 (using a patch provided by someone else in the Puppet Trac).
  • Added support for indenting continued include lines based on puppet-include-indent.
  • Fixed indentation for multiple resource definitions within one block by adding an additional indent after lines ending with a colon and dropping the indent after a semicolon.
  • Made newline indent the next line by default to match the most common behavior of other modes.
  • Fontified class references after "inherits".
  • Fontified include references on continued include lines, using an ugly hack that I need to find a better solution for.
  • Allowed underscores in types.
  • Fontified overrides like other type references.
  • Added realize to the list of keywords.
  • Cleaned up the elisp coding style to look a little more like other programming modes, although more work remains in that area.

I also took the liberty of increasing the version number.

Attachments

puppet-diff (10.3 kB) - added by rra on 03/26/08 21:59:29.
puppet-mode.el diff against current Git head
additional-diff (1.0 kB) - added by rra on 04/04/08 02:36:14.
Additional patch against puppet.el to apply on top of previous

Change History

03/26/08 21:59:29 changed by rra

  • attachment puppet-diff added.

puppet-mode.el diff against current Git head

04/03/08 10:31:17 changed by jamtur01

  • owner changed from community to luke.
  • stage changed from Unreviewed to Ready for checkin.

Pushed in commit [1c02749e8b54616043f728ed18ddec1dc4353a2d] in branch 0.24.x

04/04/08 02:36:14 changed by rra

  • attachment additional-diff added.

Additional patch against puppet.el to apply on top of previous

04/04/08 02:36:36 changed by rra

  • owner changed from luke to community.
  • stage changed from Ready for checkin to Unreviewed.

Ack, sorry, you slightly beat me to updating this ticket. I messed up some syntactical things in the first diff that I had to fix. Attached is a new diff to apply on top of the previous diff (I can also provide a patch against Git head, but since you already committed the initial one, this seemed better).

04/04/08 02:54:04 changed by jamtur01

  • owner changed from community to luke.
  • stage changed from Unreviewed to Ready for checkin.

Further fix pushed in commit [911c7fb4735e99cb5dc33ec7c2cb1deb166478b2] in branch 0.24.x

04/08/08 17:30:11 changed by luke

  • status changed from new to closed.
  • resolution set to fixed.

Merged and pushed.