PATCH: SELinux enhancements.

For convenience, here's a copy of the current version of the patch.

Up to you Luke...

I can't accept this patch until the types and providers have tests. You should be able to follow the examples of recent rspec tests to create the tests you need.

Even then, I'd lean towards this being a separate module, but there's no great way to share them right now.

test cases for the selinux patch (v1)

I've added a first attempt at some tests. I'd appreciate any additional feedback on how to improve the tests.

Ok, I added these patches to the 'selinux_patches' branch in my personal repo on github. This is what I got when I ran the test:

Loaded suite ./other/selinux
Started
..E
Finished in 0.415804 seconds.

  1) Error:
test_semodule(TestSELinux):
Puppet::DevError: Could not find a default provider for selmodule
    /Users/luke/git/puppet/lib/puppet/metatype/providers.rb:39:in `defaultprovider'
    /Users/luke/git/puppet/lib/puppet/metatype/providers.rb:182:in `default'
    /Users/luke/git/puppet/lib/puppet/metatype/attributes.rb:631:in `setdefaults'
    /Users/luke/git/puppet/lib/puppet/metatype/attributes.rb:120:in `eachattr'
    /Users/luke/git/puppet/lib/puppet/metatype/attributes.rb:115:in `each'
    /Users/luke/git/puppet/lib/puppet/metatype/attributes.rb:115:in `eachattr'
    /Users/luke/git/puppet/lib/puppet/metatype/attributes.rb:621:in `setdefaults'
    /Users/luke/git/puppet/lib/puppet/type.rb:247:in `initialize'
    /Users/luke/git/puppet/lib/puppet/metatype/instances.rb:151:in `new'
    /Users/luke/git/puppet/lib/puppet/metatype/instances.rb:151:in `create'
    ./other/selinux.rb:56:in `test_semodule'
    /Users/luke/git/puppet/lib/../vendor/gems/mocha-0.5.6/lib/mocha/test_case_adapter.rb:19:in `__send__'
    /Users/luke/git/puppet/lib/../vendor/gems/mocha-0.5.6/lib/mocha/test_case_adapter.rb:19:in `run'

3 tests, 6 assertions, 0 failures, 1 errors

Really, though, I think this makes more sense as a publicly available module; you can always monkey-patch the 'file' type, even though that's a touch ugly.

This is going to be used so rarely by the whole community it doesn't make sense to add to core, and there's no way I can add it with this few tests.

Looks like Wakko666 is going to add tests.

I disagree that it will rarely be used - I have a request from the Fedora Infrastructure guys to carry this patch in the RPM's until they are merged upstream. I'd feel much more comfortable if it is merged, though ;)

Good SELinux support is pretty important on any Fedora/RHEL/CentOS distribution.

Okay, given that lutter has said that this patch is a good idea to add to core, I've looked into it more deeply.

There are a couple of problems:

* The only test you've provided is in test/unit, rather than rspec. See Writing Tests for help on how to write rspec tests. * You still don't have complete tests. I'd like to see tests for every class you've provided. See any recent development in the master branch for examples, or the recent development in the Facter master branch. * All of your tests must pass even when there are no selinux binaries available. The reason that test is failing for me is I'm running it on an OS X box.

In terms of making all of the tests pass, you should be able to stub the provider as suitable. See the recently-committed tests for the ldap providers.

Also, it would be much easier to review your code if you pushed it to a public git repo. You can just fork the 'selinux_patches' branch in my Puppet github repo.

There are new rspec tests in the git repo at http://spook.wpi.edu/git/projects/puppet/.git

Currently the tests are for the new types. I'm still working on tests for the providers.