Puppet: System Administration Automated

Support

Ticket #1133 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

Regression in :node_name functionality

Reported by: johnf Assigned to: community
Priority: normal Milestone: 0.24.3
Component: library Version: 0.24.2
Severity: normal Keywords: node_name cert hostname fqdn
Cc: Triage Stage: Accepted
Attached Patches: Code Complexity: Medium

Description

When :node_name="cert" is specified the 'hostname' fact should be set to the SSL certificate common name instead of the results from facter. I've extended this to also set 'domain' and 'fqdn' since that makes a lot of sense to me. This fixes a regression introduced in SVN#1673

Attachments

puppet_node_name.diff (2.3 kB) - added by johnf on 03/14/08 04:01:41.
puppet_node_name.diff

Change History

03/13/08 03:45:26 changed by johnf

You can find a git branch at http://inodes.org/~johnf/git/puppet

03/13/08 04:16:37 changed by johnf

A blog post discussing the problem at http://inodes.org/blog/2008/03/13/puppet-facts-and-certificates/

03/13/08 15:21:14 changed by luke

  • stage changed from Unreviewed to Accepted.
  • milestone set to 0.24.3.

03/13/08 19:52:20 changed by luke

  • status changed from new to closed.
  • resolution set to fixed.

Applied in [056d213].

03/13/08 19:52:54 changed by luke

  • status changed from closed to reopened.
  • resolution deleted.

Oops; wrong window.

03/13/08 19:59:01 changed by luke

The patch looks good, but can you redo it against the 0.24.x branch? The master branch is the development branch, but you want this fix in the stable tree.

03/14/08 04:01:41 changed by johnf

  • attachment puppet_node_name.diff added.

puppet_node_name.diff

03/14/08 04:02:34 changed by johnf

New patch added against stable branch and git repository updated to include that branch

03/16/08 23:22:07 changed by luke

  • status changed from reopened to closed.
  • resolution set to fixed.

Great, thanks. Pushed. (commit [388cf7c3df7ce26e953949ed6fe63d76cbbb3691])

03/20/08 12:03:53 changed by jamtur01

  • status changed from closed to reopened.
  • complexity changed from Unknown to Medium.
  • resolution deleted.

Please see updated patch in #1137 and test.

03/20/08 14:59:09 changed by jamtur01

  • status changed from reopened to closed.
  • resolution set to fixed.

Closing this ticket and moving discussion to #1137.