Puppet: System Administration Automated

Support

Ticket #1020 (closed defect: fixed)

Opened 10 months ago

Last modified 8 months ago

Error reporting on OpenSSL errors should be clearer

Reported by: asa Assigned to: luke
Priority: normal Milestone: unplanned
Component: library Version:
Severity: normal Keywords:
Cc: Triage Stage: Ready for checkin
Attached Patches: Code Complexity: Trivial

Description (Last modified by jamtur01)

> puppetd --test --debug --verbose
/usr/local/lib/ruby/1.8/net/http.rb:590:in `connect': certificate verify failed (OpenSSL::SSL::SSLError)
        from /usr/local/lib/ruby/1.8/net/http.rb:590:in `connect'
        from /usr/local/lib/ruby/1.8/net/http.rb:557:in `do_start'
        from /usr/local/lib/ruby/1.8/net/http.rb:552:in `start'
        from /usr/local/lib/ruby/site_ruby/1.8/puppet/network/xmlrpc/client.rb:128:in `start'
        from /usr/local/lib/ruby/site_ruby/1.8/puppet/network/client.rb:99:in `initialize'
        from /usr/local/lib/ruby/site_ruby/1.8/puppet/network/client/master.rb:203:in `initialize'
        from /usr/local/bin/puppetd:312:in `new'
        from /usr/local/bin/puppetd:312

This could throw off a clearer error and point people to the correct bug at http://www.reductivelabs.com/trac/puppet/wiki/RubySSL-2007-006, perhaps with that url in the error like Solaris is doing these days with its error reporting.

Attachments

ssl_error_diff.patch (0.9 kB) - added by jamtur01 on 01/21/08 13:21:45.

Change History

01/21/08 07:32:17 changed by jamtur01

  • owner changed from community to jamtur01.
  • status changed from new to assigned.
  • description changed.

01/21/08 12:27:56 changed by jamtur01

Asa - what Puppet version is this?

01/21/08 13:21:45 changed by jamtur01

  • attachment ssl_error_diff.patch added.

01/21/08 13:22:37 changed by jamtur01

  • complexity changed from Unknown to Trivial.
  • stage changed from Unreviewed to Needs more info.
  • patch changed from None to Code.

Asa - try the attached patch - it should add some more precise error messages.

01/28/08 04:28:02 changed by luke

  • stage changed from Needs more info to Accepted.
  • milestone set to 0.24.2.

02/29/08 00:34:03 changed by luke

  • milestone changed from 0.24.2 to 0.24.3.

I'm bumping this, since the patch is missing lots of text, like it was cut off.

03/13/08 20:01:51 changed by luke

  • milestone changed from 0.24.3 to unplanned.

James, if you can provide a new patch, please do so. Until then, bump.

03/30/08 22:21:38 changed by Fujin

Closed #1166 as dupe.

03/31/08 00:10:53 changed by jamtur01

  • owner changed from jamtur01 to luke.
  • status changed from assigned to new.
  • stage changed from Accepted to Ready for checkin.

Updated patch in commit [4f8df9803a9ad2f31d3e86418732a230b5cee3f3] in branch 0.24.x

04/01/08 01:35:32 changed by jamtur01

After some advice from Luke I've reverted the previous commit and added [e51d05c9aa86db2911a68622fcf983e543576f07] also in branch 0.24.x.

04/08/08 17:25:29 changed by luke

  • status changed from new to closed.
  • resolution set to fixed.

Pushed a bit ago.