exec type has paramater 'env' whereas cron type has parameter 'environment'

root@puppet:/tmp# cat test.pp
exec {
   "/usr/bin/env > /tmp/env":
      environment => [
                        "HOME=/tmp/poos/and/wees",
                        "PATH=/usr/bin:/usr/bin/poo"
                     ];
}
root@puppet:/tmp# puppet --verbose --debug test.pp
info: Loading fact interfaces
info: Loading fact netmask
info: Loading fact acpi_available
debug: Creating default schedules
debug: //Exec[/usr/bin/env > /tmp/env]: Changing returns
debug: //Exec[/usr/bin/env > /tmp/env]: 1 change(s)
debug: //Exec[/usr/bin/env > /tmp/env]: Executing '/usr/bin/env > /tmp/env'
debug: Executing '/usr/bin/env > /tmp/env'
notice: //Exec[/usr/bin/env > /tmp/env]/returns: executed successfully
debug: Finishing transaction -610447648 with 1 changes
root@puppet:/tmp# egrep "HOME|PATH" env
HOME=/tmp/poos/and/wees
PATH=/usr/bin:/usr/bin/poo

path for exec.rb to change env to environment

Patch looks good to me. I've made this patch available in my public repo as commit [3a3516522245e9ca01f97703e06a91b092cfb099] of branch 0.24.x

Unfortunately, this test breaks backward compatibility.

Please make a non-functional :env parameter that just throws a warning and sets :environment, something like:

newparam(:env)
  munge do |value|
    warning "'env' is deprecated on exec; use 'environment'"
    resource[:environment] = value
  end
end

Please also include at least one test demonstrating that using the :env parameter will correctly set the :environment parameter.

Added :env parameter and tests in commit 8f0d87d498ca12417a7d20b81ba46465658fa210 of branch fix-1007 in my repository.

The existing test already demonstrates that using :env correctly sets :environment. I also added a test that shows that :environment works.

I hope this is better than my first attempt :-D

Replying to plathrop:

Added :env parameter and tests in commit 8f0d87d498ca12417a7d20b81ba46465658fa210 of branch fix-1007 in my repository. The existing test already demonstrates that using :env correctly sets :environment. I also added a test that shows that :environment works. I hope this is better than my first attempt :-D

Thanks for finishing this off :)

Pushed.